fix: use prebuilt kafka 2.8.2 container that works on amd64 AND arm64 #17366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
changed the title
bretthoerner
force-pushed
the
brett/kafka-container
branch
from
c8dc2e0 to
c1327d1
Compare
bretthoerner
changed the title
|
OK @PostHog/team-pipeline, this PR has been updated so that it is just a container image name change. It's already built and published here: https://github.com/PostHog/kafka-container |
tomasfarias
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The amd64 Kafka container was bugging me, especially because of how slow it seems to be. :)
Changes
Use a Kafka container built and published from: https://github.com/PostHog/kafka-container
How did you test this code?
Ran it locally on arm64 and amd64.